Commit Graph
5385 Commits
Author SHA1 Message Date
Juho Hiltunen ec57210cc5 Merge branch 'duplicates'
Code cleanups found with static analyzers.
2022-10-30 10:12:23 +02:00
Juho Hiltunen 8021528f5e cleanup: reduce code duplication with a new function
StatusCreateTerminatedMsg.

This is not covered by current tests.
2022-10-30 10:12:11 +02:00
Juho Hiltunen 55f1f8e113 cleanup: reduce code duplication with AddToVoicesList()
Checking for return value & continue might be redundant.
2022-10-30 10:12:11 +02:00
Juho Hiltunen d47d2d0a40 cleanup: remove duplicate StringToWord()
Found with pmd-cpd static analysis
2022-10-30 10:12:11 +02:00
Juho Hiltunen 03ebb2fd11 cleanup: reduce variable scopes dictionary.c 2022-10-30 10:12:06 +02:00
Juho Hiltunen f23ff88755 cleanup: reduce variable scopes in synthdata.c 2022-10-30 10:11:53 +02:00
Juho Hiltunen 5d4791ccd1 cleanup: reduce variable scopes in synthesize.c 2022-10-30 10:11:44 +02:00
Juho Hiltunen 54265990b5 cleanup: reduce variable scopes in wavegen.c 2022-10-30 10:11:44 +02:00
Juho Hiltunen fa575b54cb cleanup: fix knownConditionTrueFalse code smells 2022-10-30 10:11:44 +02:00
Juho Hiltunen 7c7ab9e177 cleanup: fix duplicateCondition code smell 2022-10-30 10:11:44 +02:00
Yury Popov ae97fa16b4 Remove phoneme compile_report stuff 2022-10-30 10:11:44 +02:00
Yury Popov a178ea1b13 Remove system() call from compiledata.c 2022-10-30 10:11:44 +02:00
FelipeZanabria 5738827dbf Update es-419
This fixes the intonation in Latin American Spanish questions, removes the phoneme replacement (T to s) because it is already included in phonemes es_la. It also eliminates the line languaje es 6, because when the voice is in the dialect of Spain and it automatically changes to the dialect of Latin America, it does not return to the dialect of Spain.
2022-10-30 10:11:44 +02:00
Beqa Gozalishvili 5ded10cf93 Add missing compatibility check for older android versions. 2022-10-30 10:11:44 +02:00
kirill-jjj 1bb3109181 Russian: add a new variant, Russian (classic) 2022-10-30 10:11:44 +02:00
kirill-jjj 16b2406f06 Russian: fix for модель rule 2022-10-30 10:11:44 +02:00
Yury Popov 3857b83c19 Respect custom N_PATH_HOME definition if passed 2022-10-30 10:11:44 +02:00
Alexander Epaneshnikov 6f6a1223e6 Allow phoneme compilation without report generation (#1473)
When compile from read-only data bundle (shipped within iOS/macOS app),
we can't write compile_report file.
The simplest solution is to (almost) silently discard it.
2022-10-30 02:54:47 +03:00
Yury Popov 1f571856b5 Remove phoneme compile_report stuff 2022-10-30 02:33:01 +03:00
Alexander Epaneshnikov 08685aaa0f Remove system() call from compiledata.c (#1475) 2022-10-29 18:19:27 +03:00
Yury Popov 8478d39eb1 Remove system() call from compiledata.c 2022-10-29 15:30:26 +03:00
Juho Hiltunen 19f98ed699 Update es-419 (#1436)
This fixes the intonation in Latin American Spanish questions, removes
the phoneme replacement (T to s) because it is already included in
phonemes es_la. It also eliminates the line languaje es 6, because when
the voice is in the dialect of Spain and it automatically changes to the
dialect of Latin America, it does not return to the dialect of Spain.
2022-10-29 15:02:33 +03:00
Alexander Epaneshnikov b38f563af8 Add missing compatibility check for older android versions. (#1472)
Note: this doesn't fix actual problem for some of the older devices.
Unfortunately i don't have devices with os version below than android 7,
so am not able to test.
2022-10-28 18:48:36 +03:00
Beqa Gozalishvili e36b3d9499 Add missing compatibility check for older android versions. 2022-10-28 19:27:01 +04:00
Alexander Epaneshnikov 7d6deaf35b Russian update (#1459) 2022-10-28 17:31:21 +03:00
kirill-jjj 0997416aec Russian: add a new variant, Russian (classic) 2022-10-28 17:01:49 +03:00
kirill-jjj 66f6b73673 Russian: fix for модель rule 2022-10-28 17:01:48 +03:00
Alexander Epaneshnikov 43bf99a1e9 Respect custom N_PATH_HOME definition if passed (#1469)
On e.g. iOS it may be very long.

Helps to make #1291
2022-10-28 16:41:39 +03:00
Alexander Epaneshnikov aea62ae959 Allow out-of-tree intonations compilation (#1470)
So we can ship data bundle and compile it AOT.

Helps to make #1291
2022-10-28 16:34:40 +03:00
Yury Popov 4e5bc19047 Allow out-of-tree intonations compilation 2022-10-28 12:34:56 +03:00
Yury Popov 99dc51ca3a Respect custom N_PATH_HOME definition if passed 2022-10-28 12:27:52 +03:00
Juho Hiltunen 385105b7cd Merge branch 'staticanalysis'
Fixes for some code smells found with cppcheck static code analysis tool.
2022-10-26 17:57:05 +03:00
Juho Hiltunen 507a5f5410 cleanup: fix unreadVariable code smell for variant_name in SelectVoiceByName() 2022-10-26 17:55:00 +03:00
Juho Hiltunen 14f12376a3 cleanup: change int skip to bool 2022-10-26 17:55:00 +03:00
Juho Hiltunen 8ddcf6ed94 cleanup: reduce variable scopes in voices.c 2022-10-26 17:54:55 +03:00
Juho Hiltunen 9900d55ccf cleanup: reduce variable scopes in setlengths.c 2022-10-25 20:02:54 +03:00
Juho Hiltunen 78a037924e cleanup: fix code smell knownConditionTrueFalse for strlen() >= 0
Strlen never retuns a negative value. Also combined if statements to
reduce complexity. This code currently has no tests.
2022-10-25 19:51:02 +03:00
Juho Hiltunen 07da7edeea cleanup: fix code smell knownConditionTrueFalse
Inner 'n_bytes >= 0' will always be true.
2022-10-25 19:51:02 +03:00
Juho Hiltunen 59177db8ef cleanup: fix code smell knownConditionTrueFalse
Inner 'p->stresslevel>=4' will always be true. Thus checking for
count_stressed is redundant.
2022-10-25 19:51:02 +03:00
Juho Hiltunen ef809dcd7e SetSpeed() refactoring (#1465)
Unify common parts of two implementations. Split into smaller functions.
2022-10-25 19:32:32 +03:00
Juho Hiltunen d1e98942e3 Update README.md (#1442)
Google is now a LLC not Inc.
2022-10-25 19:30:55 +03:00
Juho Hiltunen b94a5b160b Add arm CI (#1463)
This allows to cover
- another arch that x86, which is also very common
- an arch where char is unsigned
- a little-endian arch

This is running under qemu-user, so significantly slower and doesn't
support ptrace thus no address sanitizer etc. but at least the undefined
sanitizer works.
2022-10-25 19:29:20 +03:00
Juho Hiltunen 8170775113 code cleanup: refactor and remove duplication by unifying SetSpeed()
implemantations.

It is unclear why the two implementations differ.
2022-10-25 19:24:55 +03:00
Juho Hiltunen 0c82988b44 cleanup: refactor and remove duplication from SetSpeed() implementations. 2022-10-25 19:24:55 +03:00
Juho Hiltunen 84f58824af cleanup: refactor and remove duplication from SetSpeed() implementations. 2022-10-25 19:24:55 +03:00
Juho Hiltunen 9e9fb16b56 cleanup: use parameters instead of globals with SetSpeedMods 2022-10-25 19:24:55 +03:00
Juho Hiltunen a4c70d7921 cleanup: remove setting samplerate with Sonic.
we currently only support 22050 as samplerate so this code has no
effect. This should be readded to setSpeed() with and without Sonic if
multiple samplerates are supported in the future.
2022-10-25 18:24:27 +03:00
Samuel Thibault 4f556bb4fd Add arm CI
This allows to cover
- another arch that x86, which is also very common
- an arch where char is unsigned
- a little-endian arch

This is running under qemu-user, so significantly slower and doesn't support
ptrace thus no address sanitizer etc. but at least the undefined sanitizer
works.
2022-10-25 13:59:27 +02:00
Samuel Thibault 548c3e3069 Factorize deps list (#1462) 2022-10-24 22:37:34 +02:00
Samuel Thibault 4281b15f4f Factorize deps list 2022-10-24 22:13:38 +02:00