Commit Graph
36 Commits
Author SHA1 Message Date
Samuel Thibault 977bff9a06 event_notify: Remove spurious 50ms delay
event_notify currently introduces an arbitrary 50ms delay between speech
requests. This is usually unnoticed since it's small. But when
cancelling a long series of events, they add up to potentially seconds
of delays, while the user was precisely requesting to just cancel
everything as fast as possible.

This 50ms delay was probably meant to work around some issues elsewhere.
If they are still there, they should be fixed, not worked around.
2022-02-13 02:54:00 +01:00
freddii 61efed30fa fixed spelling mistakes 2021-01-13 01:55:34 +01:00
Samuel Thibault 04a8a619b6 Fix termination test in event processing
e13b602 ("Avoid using pthread_cancel") introduced a bogus termination test,
this fixes it.

Fixes #572
2018-12-19 15:54:21 +01:00
Samuel Thibault e13b602ce0 Avoid using pthread_cancel
If a thread is cancelled while it holds a mutex, other threads waiting for
the mutex will never be woken, even if destroying the mutex, thus
leading to a deadlock.

Better just make the thread loops have a proper exit case than risking
the tricky semantic of pthread_cancel.
2018-11-13 01:55:17 +01:00
Juho Hiltunen 079d5a92c5 remove more unnecessary speech.h includes 2018-03-09 21:08:38 +02:00
Juho Hiltunen 4f56345fb5 Use stdbool instead of int (Issue #8)
See issue #8, https://github.com/espeak-ng/espeak-ng/issues/8

There might still be some ints that could be changed to boolean.

Possible regressions in fifo.c:
int fifo_is_busy() and int fifo_is_command_enabled() used to return an int. Now they return a boolean. This might cause problems on systems where stdbool true/false is something else than 1/0.
2017-12-09 17:34:05 +02:00
Reece H. Dunn ba62f9a162 event.c: Fix -Wmissing-prototypes warnings. 2017-10-06 07:11:17 +01:00
Reece H. Dunn 977c85ad6e Enable and fix -Wunused-but-set-variable warnings. 2017-10-05 07:35:10 +01:00
Christopher Brannon 0436ae71c0 Mutex needs to be locked when waiting on the condition variable. 2016-10-10 18:24:15 -07:00
Reece H. Dunn 2893de65ac Ensure that the code is consistently formatted. 2016-10-09 17:39:01 +01:00
Rui Batista cc51af059f Use condition variables in event.c instead of semaphores. 2016-10-09 17:20:31 +01:00
Ondřej Lysoněk 3817ee1e16 Moved speak_lib.h to espeak-ng directory
Moved include/espeak/speak_lib.h to include/espeak-ng/speak_lib.h and
created a symlink from the original location.
2016-08-28 10:57:10 +01:00
Reece H. Dunn bd9eef8550 event: sleep_until_timeout_or_stop_request is not used, so remove it. 2016-06-05 08:52:16 +01:00
Reece H. Dunn bb465a45d8 Move the clock_gettime2 and add_time_in_ms definitions to event.h. 2016-02-07 18:38:13 +00:00
Reece H. Dunn 4a2994d1d3 Remove calls to wave_get_remaining_time.
This logic was implemented to limit the number of audio events sent
to a device, but the logic is not too relevant in practice (these
calls return 0 most of the time), and the logic is broken (e.g. when
calling Synthesize with a very long block of text).
2016-02-07 16:12:39 +00:00
Reece H. Dunn 7d900fb8b0 Remove includes from internal header files. 2016-01-16 18:05:17 +00:00
Reece H. Dunn 96c43f3eb2 Clean up the include files to make them consistent. 2016-01-16 17:54:39 +00:00
Reece H. Dunn 9c5820f72a Create an initial compatibility shim for unistd.h. 2016-01-15 07:22:46 +00:00
Reece H. Dunn 0ca520a4ec Revert the gcc sign conversion warning fixes.
This reverts commits 0cc0300328 to
38d15f8f90.

The 0cc03003 commit breaks MBROLA voice support. As such, there
may be other breakages in those commits.
2016-01-11 07:03:00 +00:00
Reece H. Dunn aa3de904e8 Fix gcc sign conversion warnings in event.c. 2016-01-10 18:17:44 +00:00
Reece H. Dunn 72db232ec3 Move include/espeak{-ng => }/speak_lib.h. 2016-01-04 19:45:23 +00:00
Reece H. Dunn a8eb65ee61 Fix the logic from commit 3343bb45b6 that caused the end of the speech to be clipped. 2016-01-03 20:44:27 +00:00
Reece H. Dunn 3343bb45b6 Make the event API use espeak_ng_STATUS. 2016-01-02 19:17:19 +00:00
Reece H. Dunn 2e88afeaa0 Move the clock_gettime2 and add_time_in_ms implementation to event.c to avoid code duplication. 2015-12-31 16:51:46 +00:00
Reece H. Dunn b11d540718 Fix GCC -Wunused-parameter warnings. 2015-12-30 15:01:31 +00:00
Reece H. Dunn e69c936329 Remove the debugging code.
The debugging code is done inconsistently, mainly to trace the
event and audio output logic. This makes it harder to understand
the code flow for logic that is not enabled by default.

As such the debugging code makes the code harder to maintain.
2015-12-28 12:33:14 +00:00
Reece H. Dunn 3e99752d0c Check and fix source code formatting. 2015-12-27 22:34:53 +00:00
Reece H. Dunn f0c2c4cca2 Remove extra newlines from the files to provide consistent spacing. 2015-12-23 11:32:03 +00:00
Reece H. Dunn d345d74f64 Remove braces around single-line if/while/for/etc. and related cleanup. 2015-12-22 20:40:10 +00:00
Reece H. Dunn 12e0bb122b Reformat the code using the uncrustify program. 2015-12-22 15:06:50 +00:00
Reece H. Dunn 66c2831bed Use intptr_t from stdint.h instead of a custom long64 typedef. 2015-12-18 21:41:28 +00:00
Reece H. Dunn c71b24a9a5 Use a consistent license notice in the source files. 2015-12-18 07:06:29 +00:00
Reece H. Dunn cbe8695fcb Remove the * box around the file headers. 2015-12-17 23:45:36 +00:00
Reece H. Dunn 36be9ac13f Use the default uncrustify config (with indentation changes) to reformat the code. 2015-12-17 07:40:24 +00:00
Reece H. Dunn 08821f262f Remove commented out code. 2015-12-14 23:13:56 +00:00
Reece H. Dunn f7dfc38dd7 Use the C compiler to build C files; restructuring.
This moves the libespeak source (*.cpp) files to src/libespeak-ng
and renames the C files (libespeak, espeak, speak) so they have
a .c file extension.
2015-12-09 23:33:00 +00:00