From dab5457620af86a8703d6b247ecc5df4d9a3c9cf Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Tue, 15 Mar 2022 21:32:38 +0100 Subject: [PATCH] Fix deleting FrameManagerImpl* delete playerHandleInfo->frameManager wasn't actually calling FrameManagerImpl~, because playerHandleInfo->frameManager is only a FrameManager, which didn't have a destructor, and nothing was saying that it's actually a FrameManagerImpl behind. Adding a virtual destructor fixes that. --- src/speechPlayer/src/frame.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/speechPlayer/src/frame.h b/src/speechPlayer/src/frame.h index a3f8c22f..73de5694 100644 --- a/src/speechPlayer/src/frame.h +++ b/src/speechPlayer/src/frame.h @@ -51,6 +51,7 @@ class FrameManager { virtual void queueFrame(speechPlayer_frame_t* frame, unsigned int minNumSamples, unsigned int numFadeSamples, int userIndex, bool purgeQueue)=0; virtual const speechPlayer_frame_t* const getCurrentFrame()=0; virtual const int getLastIndex()=0; + virtual ~FrameManager() {}; }; #endif