From 261954b4bde96ff35cdf20ecd27000c5dc3a744b Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 19 Mar 2022 10:50:28 +0100 Subject: [PATCH] Fix deleting SpeechWaveGenerator Similarly to dab5457620af "Fix deleting FrameManagerImpl*", we need a virtual destructor. clang was complaining about it: src/speechPlayer/src/speechPlayer.cpp:52:2: warning: delete called on 'SpeechWaveGenerator' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor] delete playerHandleInfo->waveGenerator; ^ --- src/speechPlayer/src/speechWaveGenerator.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/speechPlayer/src/speechWaveGenerator.h b/src/speechPlayer/src/speechWaveGenerator.h index 9b9f7c45..968149e8 100644 --- a/src/speechPlayer/src/speechWaveGenerator.h +++ b/src/speechPlayer/src/speechWaveGenerator.h @@ -23,6 +23,7 @@ class SpeechWaveGenerator: public WaveGenerator { public: static SpeechWaveGenerator* create(int sampleRate); virtual void setFrameManager(FrameManager* frameManager)=0; + virtual ~SpeechWaveGenerator() {}; }; #endif