From 05d9a4839c1ac792b9a3842e6bd0ad13c5316359 Mon Sep 17 00:00:00 2001 From: "Reece H. Dunn" Date: Thu, 5 Oct 2017 20:14:06 +0100 Subject: [PATCH] Enable and fix -Wmissing-prototypes warnings. --- configure.ac | 1 + tests/printcdata.c | 12 ++++++------ tests/printucddata.c | 12 ++++++------ 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 46fc4cba..399f99e9 100644 --- a/configure.ac +++ b/configure.ac @@ -47,6 +47,7 @@ dnl dnl Reference: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html dnl ================================================================ +AX_CHECK_COMPILE_FLAG([-Wmissing-prototypes], [CFLAGS="-Wmissing-prototypes $CFLAGS"]) AX_CHECK_COMPILE_FLAG([-Wreturn-type], [CFLAGS="-Wreturn-type $CFLAGS"]) dnl ================================================================ diff --git a/tests/printcdata.c b/tests/printcdata.c index 6992bb94..9d0ab18a 100644 --- a/tests/printcdata.c +++ b/tests/printcdata.c @@ -33,7 +33,7 @@ static int iswblank(wint_t c) } #endif -void fput_utf8c(FILE *out, codepoint_t c) +static void fput_utf8c(FILE *out, codepoint_t c) { if (c < 0x80) fputc((uint8_t)c, out); @@ -57,7 +57,7 @@ void fput_utf8c(FILE *out, codepoint_t c) } } -int fget_utf8c(FILE *in, codepoint_t *c) +static int fget_utf8c(FILE *in, codepoint_t *c) { int ch = EOF; if ((ch = fgetc(in)) == EOF) return 0; @@ -90,7 +90,7 @@ int fget_utf8c(FILE *in, codepoint_t *c) return 1; } -void uprintf_codepoint(FILE *out, codepoint_t c, char mode) +static void uprintf_codepoint(FILE *out, codepoint_t c, char mode) { switch (mode) { @@ -112,7 +112,7 @@ void uprintf_codepoint(FILE *out, codepoint_t c, char mode) } } -void uprintf_is(FILE *out, codepoint_t c, char mode) +static void uprintf_is(FILE *out, codepoint_t c, char mode) { switch (mode) { @@ -155,7 +155,7 @@ void uprintf_is(FILE *out, codepoint_t c, char mode) } } -void uprintf(FILE *out, codepoint_t c, const char *format) +static void uprintf(FILE *out, codepoint_t c, const char *format) { while (*format) switch (*format) { @@ -221,7 +221,7 @@ void uprintf(FILE *out, codepoint_t c, const char *format) } } -void print_file(FILE *in, const char *format) +static void print_file(FILE *in, const char *format) { codepoint_t c = 0; while (fget_utf8c(in, &c)) diff --git a/tests/printucddata.c b/tests/printucddata.c index b592f820..9a623bf3 100644 --- a/tests/printucddata.c +++ b/tests/printucddata.c @@ -22,7 +22,7 @@ #include #include -void fput_utf8c(FILE *out, codepoint_t c) +static void fput_utf8c(FILE *out, codepoint_t c) { if (c < 0x80) fputc((uint8_t)c, out); @@ -46,7 +46,7 @@ void fput_utf8c(FILE *out, codepoint_t c) } } -int fget_utf8c(FILE *in, codepoint_t *c) +static int fget_utf8c(FILE *in, codepoint_t *c) { int ch = EOF; if ((ch = fgetc(in)) == EOF) return 0; @@ -79,7 +79,7 @@ int fget_utf8c(FILE *in, codepoint_t *c) return 1; } -void uprintf_codepoint(FILE *out, codepoint_t c, char mode) +static void uprintf_codepoint(FILE *out, codepoint_t c, char mode) { switch (mode) { @@ -101,7 +101,7 @@ void uprintf_codepoint(FILE *out, codepoint_t c, char mode) } } -void uprintf_is(FILE *out, codepoint_t c, char mode) +static void uprintf_is(FILE *out, codepoint_t c, char mode) { switch (mode) { @@ -144,7 +144,7 @@ void uprintf_is(FILE *out, codepoint_t c, char mode) } } -void uprintf(FILE *out, codepoint_t c, const char *format) +static void uprintf(FILE *out, codepoint_t c, const char *format) { while (*format) switch (*format) { @@ -210,7 +210,7 @@ void uprintf(FILE *out, codepoint_t c, const char *format) } } -void print_file(FILE *in, const char *format) +static void print_file(FILE *in, const char *format) { codepoint_t c = 0; while (fget_utf8c(in, &c))